miri: implement most floating point math operations using soft floats#3969
Closed
eduardosm wants to merge 1 commit intorust-lang:masterfrom
Closed
miri: implement most floating point math operations using soft floats#3969eduardosm wants to merge 1 commit intorust-lang:masterfrom
eduardosm wants to merge 1 commit intorust-lang:masterfrom
Conversation
Member
|
Thanks for the PR! Implementation-wise it looks great (I would have some minor comments but it's not worth going into them yet). As already mentioned, my main concern here is about pulling in a not-widely-used (and not-widely-vetted) third-party dependency to fix something that's not fundamentally wrong. The only part of this that is a bugfix is using a softfloat implementation for How large is an |
Contributor
|
☔ The latest upstream changes (presumably #4009) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preview of how it would look to implement math intrinsics using soft floats.
Deterministic non-determinism (
this.machine.rng) is used to apply some random error to the results to model the non-guaranteed precision (except for sqrt).cc #3898